update tray menu before sending MenuDiff event

[Levizor]

fixed #20 for me

[Levizor]

Now also updating StatusNotifierItem on properties update.

[JakeStanger]

Thanks for this.

Re-fetching the entire menu isn't supposed to be necessary when fetching a single property, but it does not shock me at all that there are implementations bad enough to make it necessary.

This does effectively duplicate the layout updated case above - if we're re-fetching the layout in both, could you look to see if you could condense them down please?

[Levizor]

Thanks for this.

Re-fetching the entire menu isn't supposed to be necessary when fetching a single property, but it does not shock me at all that there are implementations bad enough to make it necessary.

This does effectively duplicate the layout updated case above - if we're re-fetching the layout in both, could you look to see if you could condense them down please?

I used this as a quick fix to make my project work, cause I didn't bother creating my own implementation of this map.

I agree that it should be rewritten and ideally we should update only the changed properties in TrayMenu and StatusNotifierItem.

I may have some time to try tackling this problem, but I should warn you that I am very new to Rust, so it's better to double-check my code and possibly direct me with finding out solution.

For this specific case I guess I'll need to create a function to apply vector of MenuDiffs to the actual menu and similarly for the status notifier item.

[Levizor]

Seems to work. Now it doesn't re-fetch entire menu but applies the updates to the existing ones in items map.
Had to adapt to upstream/master which hides map behind the feature flag. I suppose I should hide new methods inside TrayItemMap. Will work on it soon.

[Levizor]

Let me know what you think and what changes should be applied.

I also wonder why there is no methods implemented on the actual structures such as TrayMenu or MenuItem to feed updates/diffs for them to change. I think it would be beneficial to have those, in case of disabled "data" feature as well.

Or maybe I missed something and my implementations to apply updates to the structures is redundant or inefficient?