Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black text in Dark mode inside "Citation information" #11512

Closed
2 tasks done
InAnYan opened this issue Jul 17, 2024 · 5 comments · Fixed by #11578
Closed
2 tasks done

Black text in Dark mode inside "Citation information" #11512

InAnYan opened this issue Jul 17, 2024 · 5 comments · Fixed by #11578
Assignees
@ankur-kalita
Labels
component: theming component: ui FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@InAnYan
Copy link
Member

InAnYan commented Jul 17, 2024 •
edited by subhramit
Loading

JabRef version

5.15 (latest release)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Set theme to "Dark".
  2. Select a bib entry.
  3. Open "Citation information" tab

изображение

Appendix

No response
@github-project-automation github-project-automation bot moved this to Normal priority in JabRef UI Improvements Jul 17, 2024
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jul 17, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Jul 17, 2024
@InAnYan
Copy link
Member Author

InAnYan commented Jul 17, 2024

I wonder, what is the CSS class for text color?

I couldn't find it neither in Base.css, nor in Dark.css.

Then, how Dark.css make some text white?

@InAnYan
Copy link
Member Author

InAnYan commented Jul 17, 2024 •
edited
Loading

To anyone who will try to solve this issue, here is a little hint:

Try to determine, when text is colored properly and when it's not

@ankur-kalita
Copy link

Hi @InAnYan @Siedlerchr ,

I'd like to work on this issue. Could you please assign it to me?

@koppor koppor added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Jul 18, 2024
@koppor koppor moved this from Free to take to Reserved in Good First Issues Jul 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

shivenducs1136 added a commit to shivenducs1136/jabref that referenced this issue Aug 5, 2024
@shivenducs1136
fix JabRef#11512
64a4b85
@shivenducs1136 shivenducs1136 mentioned this issue Aug 5, 2024
Merged
@shivenducs1136
Copy link
Contributor

Hi @InAnYan,

This pull request is related to issue #11578.

I've implemented the requested changes and would appreciate your review.

Thank you!

github-merge-queue bot pushed a commit that referenced this issue Aug 6, 2024
@shivenducs1136 @koppor @Siedlerchr
Fix black text in Dark mode inside "Citation information" (#11578)
dfaa5f4 
* fix #11512

* Fix typos and use of Logger

* Switch to id

* Works with class

* Works without class

---------

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@github-project-automation github-project-automation bot moved this from Reserved to Done in Good First Issues Aug 6, 2024
@github-project-automation github-project-automation bot moved this from Normal priority to Closed in JabRef UI Improvements Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankur-kalita ankur-kalita

Labels
component: theming component: ui FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Good First Issues
Archived in project
JabRef UI Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix black text in Dark mode inside "Citation information" shivenducs1136/jabref
6 participants
@Siedlerchr @koppor @InAnYan @ThiloteE @shivenducs1136 @ankur-kalita