Skip to content

Commit

Permalink
small changes based on code review
Browse files Browse the repository at this point in the history
  • Loading branch information
FlorianKirmaier committed Feb 4, 2025
1 parent f98ea7c commit b04442f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Added DirectoryOpenPicker to the jpro-file module. This allows the user to select a directory instead of a file.

#### Bufixes
* Fixed issue, with jpro-file. Drag&Drop file extensions are now handled case-insensitive, like in the rest of jpro-file.
* Fixed issue, with jpro-file. FileDropper file extensions are now handled case-insensitive, like in the rest of jpro-file.

----------------------

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ public Parent createRoot(Stage stage) {

FileDropper fileDropper = FileDropper.create(contentPane);
fileDropper.setExtensionFilter(SUBTITLE_EXTENSION_FILTER);
// Nah?
fileDropper.setOnDragEntered(event -> {
dropPane.pseudoClassStateChanged(FILES_DRAG_OVER_PSEUDO_CLASS, true);
contentPane.getChildren().setAll(textArea, dropPane);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
import java.util.Objects;

/**
* {@link FilePicker} interface extension for file open operations.
* {@link DirectoryOpenPicker} interface extension for directory open operations.
*
* @author Florian Kirmaier
*/
public interface DirectoryOpenPicker extends FileOpenPicker {

/**
* Creates a file picker.
* Creates a directory picker.
* It only works in desktop applications.
*
* @param node the associated node for this file picker
* @param node the associated node for this directory picker
* @return a {@link DirectoryOpenPicker} object.
* @throws NullPointerException if the node is null
*/
Expand Down

0 comments on commit b04442f

Please sign in to comment.