Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use new API for deleting a room #37

Closed
rht opened this issue May 26, 2021 · 2 comments
Closed

Update to use new API for deleting a room #37

rht opened this issue May 26, 2021 · 2 comments
Labels
core feature Feature request, has priority over regular features help wanted Extra attention is needed

Comments

@rht
Copy link
Contributor

rht commented May 26, 2021

Currently, the old POST method is used: self.query("post", f"v1/rooms/{room_id}/delete", data=data) (https://github.com/JOJ0/synadm/blob/master/synadm/api.py#L384).

The new route is
DELETE /_synapse/admin/v1/rooms/<room_id>.

See matrix-org/synapse#9889.
@JOJ0
Copy link
Owner

JOJ0 commented Jun 24, 2021 •
edited
Loading

Hi @rht , thanks a lot for the hint. If you find the time a PR would be welcomed, if not I hope deprecation state will last for a while. I currently try to finally put out a new version with focus on "login as user and related topics" and that's where my "synadm time" currently is spent ;-)

@JOJ0 JOJ0 added core feature Feature request, has priority over regular features help wanted Extra attention is needed labels Jul 8, 2021
JOJ0 added a commit that referenced this issue Sep 21, 2021
@JOJ0
api room_delete: post deprecated, use delete method
50b674c 
fixes issue #37
@JOJ0
Copy link
Owner

JOJ0 commented Sep 21, 2021

Finally fixed this. Thanks for the hint @rht!

@JOJ0 JOJ0 closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core feature Feature request, has priority over regular features help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rht @JOJ0