Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

PLT-1219 Remove offchain logic for MustProduceAtLeast and MustSpendAtLeast #817

Merged
merged 10 commits into from
Nov 16, 2022

Conversation

berewt
Copy link
Contributor

@berewt berewt commented Nov 10, 2022

Offchain use of MustProduceAtLeast and MustSpendAtLeast now checks if we have produced/spent at least the given amount when we create the Tx, and throw an error if it isn't the case. (see PLT-665 for the rationale behind this change)

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given my Address PR, I'm all for removing slOwnPaymentPubKeyHash and slOwnStakingCredential.

@berewt
Copy link
Contributor Author

berewt commented Nov 10, 2022

Given my Address PR, I'm all for removing slOwnPaymentPubKeyHash and slOwnStakingCredential.

It's great to see synergies on apparently disconnected PR :)

@berewt berewt marked this pull request as draft November 10, 2022 16:32
@berewt berewt marked this pull request as ready for review November 15, 2022 10:04
@berewt berewt merged commit c6703a4 into main Nov 16, 2022
@berewt berewt deleted the nicolas/PLT-665 branch November 16, 2022 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants