This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
PLT-1219 Remove offchain logic for MustProduceAtLeast and MustSpendAtLeast #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given my Address
PR, I'm all for removing slOwnPaymentPubKeyHash
and slOwnStakingCredential
.
It's great to see synergies on apparently disconnected PR :) |
fd1a662
to
339aec8
Compare
6af86d4
to
573395a
Compare
koslambrou
approved these changes
Nov 15, 2022
sjoerdvisscher
suggested changes
Nov 15, 2022
plutus-contract/test/Spec/Contract/Tx/Constraints/MustProduceAtLeast.hs
Outdated
Show resolved
Hide resolved
sjoerdvisscher
approved these changes
Nov 15, 2022
484667a
to
12f0004
Compare
12f0004
to
55d2460
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offchain use of
MustProduceAtLeast
andMustSpendAtLeast
now checks if we have produced/spent at least the given amount when we create the Tx, and throw an error if it isn't the case. (see PLT-665 for the rationale behind this change)Pre-submit checklist: