Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Fix onchain MustPayToPubKeyAddress check #648

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix onchain MustPayToPubKeyAddress check #648

merged 1 commit into from
Aug 5, 2022

Conversation

sjoerdvisscher
Copy link
Contributor

Returning True in an any function meant that the check would succeed if there was any other output.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@sjoerdvisscher sjoerdvisscher requested a review from a user August 5, 2022 08:45
@sjoerdvisscher sjoerdvisscher force-pushed the fix-onchain-MustPayToPubKeyAddress-check branch from b7551f5 to a19b4cb Compare August 5, 2022 09:20
ghost
ghost approved these changes Aug 5, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sjoerdvisscher sjoerdvisscher force-pushed the fix-onchain-MustPayToPubKeyAddress-check branch from a19b4cb to 86a71e2 Compare August 5, 2022 10:30
@sjoerdvisscher sjoerdvisscher merged commit 5d0da72 into main Aug 5, 2022
@sjoerdvisscher sjoerdvisscher deleted the fix-onchain-MustPayToPubKeyAddress-check branch August 5, 2022 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjoerdvisscher