Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

cardano-ledger validation rules are prioritized over custom validaton rules #639

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

koslambrou
Copy link
Contributor

@koslambrou koslambrou commented Aug 2, 2022

cardano-ledger validation rules are prioritized over our custom validation rules when validating transaction in the emulator.

Simple change, but creating a PR for this in order to make sure everything compiles and all test cases pass.

Should fix the test case of #624

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

…ation rules when validating transaction in the emulator
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice in-between step before removing our own validation.

@koslambrou koslambrou marked this pull request as ready for review August 2, 2022 14:35
@koslambrou koslambrou merged commit d7423d3 into main Aug 2, 2022
@koslambrou koslambrou deleted the kll/prioritize-cardano-ledger-rules branch August 2, 2022 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants