-
Notifications
You must be signed in to change notification settings - Fork 214
deleted Marlowe content, updated project name and copyright year #534
Conversation
doc/index.rst
Outdated
=============================== | ||
|
||
The Plutus Platform is an application development platform for the Cardano blockchain. | ||
To read more about the Platform, see :ref:`what_is_the_plutus_platform`. | ||
To read more about the Platform, see :ref:`what_is_the_plutus_platform` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dot (.) probably makes sense here at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koslambrou @michaelpj
I find it strange to see a question mark followed immediately by a period. Logically, I see that it makes sense because the heading being referenced includes a question mark, and a period at the end of the whole sentence is logical. However, it jumped out at me as something that didn't look right to my eye. For reference, have a look at this link:
https://www.thepunctuationguide.com/terminal-points.html
It states that "The general rule is that a sentence ends with only one terminal punctuation mark."
I think either approach is legitimate. My preference is to use a single terminal punctuation mark. But it's a minor issue.
doc/reference/glossary.rst
Outdated
@@ -59,7 +59,7 @@ Glossary | |||
|
|||
This is implemented in the Alonzo hard fork of the Cardano blockchain. | |||
|
|||
See :ref:`what_is_a_ledger`. | |||
See :ref:`what_is_a_ledger` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all these changes? is it not grammatical to have a full stop at the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koslambrou @michaelpj
I find it strange to see a question mark followed immediately by a period. Logically, I see that it makes sense because the heading being referenced includes a question mark, and a period at the end of the whole sentence is logical. However, it jumped out at me as something that didn't look right to my eye. For reference, have a look at this link:
https://www.thepunctuationguide.com/terminal-points.html
It states that "The general rule is that a sentence ends with only one terminal punctuation mark."
I think either approach is legitimate. My preference is to use a single terminal punctuation mark. But it's a minor issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative approach would be to use a different link text in that circumstance.
I wanted to remove the periods that followed headings that had question
marks included, to avoid instances of "?." because to my eye it looks a
little odd. If you disagree with that I'll look into it a little further.
…On Wed, Jun 22, 2022, 11:25 AM Michael Peyton Jones < ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#534 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AY7P25LDFCSKVX4R2BCZ73TVQNLBRANCNFSM5ZQKZVLA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Reverting a deleted period
Reverting a handful of periods
No description provided.