Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

deleted Marlowe content, updated project name and copyright year #534

Merged
merged 4 commits into from
Jun 24, 2022

Conversation

joseph-fajen
Copy link
Contributor

No description provided.

doc/index.rst Outdated
===============================

The Plutus Platform is an application development platform for the Cardano blockchain.
To read more about the Platform, see :ref:`what_is_the_plutus_platform`.
To read more about the Platform, see :ref:`what_is_the_plutus_platform`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dot (.) probably makes sense here at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koslambrou @michaelpj
I find it strange to see a question mark followed immediately by a period. Logically, I see that it makes sense because the heading being referenced includes a question mark, and a period at the end of the whole sentence is logical. However, it jumped out at me as something that didn't look right to my eye. For reference, have a look at this link:

https://www.thepunctuationguide.com/terminal-points.html

It states that "The general rule is that a sentence ends with only one terminal punctuation mark."

I think either approach is legitimate. My preference is to use a single terminal punctuation mark. But it's a minor issue.

@@ -59,7 +59,7 @@ Glossary

This is implemented in the Alonzo hard fork of the Cardano blockchain.

See :ref:`what_is_a_ledger`.
See :ref:`what_is_a_ledger`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all these changes? is it not grammatical to have a full stop at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koslambrou @michaelpj
I find it strange to see a question mark followed immediately by a period. Logically, I see that it makes sense because the heading being referenced includes a question mark, and a period at the end of the whole sentence is logical. However, it jumped out at me as something that didn't look right to my eye. For reference, have a look at this link:

https://www.thepunctuationguide.com/terminal-points.html

It states that "The general rule is that a sentence ends with only one terminal punctuation mark."

I think either approach is legitimate. My preference is to use a single terminal punctuation mark. But it's a minor issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative approach would be to use a different link text in that circumstance.

@joseph-fajen
Copy link
Contributor Author

joseph-fajen commented Jun 22, 2022 via email

@joseph-fajen joseph-fajen marked this pull request as ready for review June 24, 2022 16:15
@joseph-fajen joseph-fajen enabled auto-merge (squash) June 24, 2022 16:17
@joseph-fajen joseph-fajen merged commit db318b4 into main Jun 24, 2022
@joseph-fajen joseph-fajen deleted the josfaj/PLT-00-test-first-PR branch June 24, 2022 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants