Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

ContractModel: Report symbolic values as their symbolic names #452

Merged
merged 8 commits into from
May 31, 2022
Merged

ContractModel: Report symbolic values as their symbolic names #452

merged 8 commits into from
May 31, 2022

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented May 10, 2022 •
edited
Loading

This PR cleans up the counterexamples reported by ContractModel code to be a bit cleaner.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-ContractModel-polish branch from 5dd9e1d to 45bff3e Compare May 10, 2022 08:06
@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher in your own time.

@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher neither the local CI build failure or the hydra CI build failure makes any sense to me. Do you know what's goin on here?

@sjoerdvisscher
Copy link
Contributor

When it says "Killed" the build server probably ran out of memory. This seems to happen more frequently recently and it's really annoying since this result is cached.

You could try to retrigger the build by making a small change in one of the mentioned modules.

@MaximilianAlgehed
Copy link
Contributor Author

Is there no way to tell hydra to rebuild everything?

@MaximilianAlgehed
Copy link
Contributor Author

MaximilianAlgehed commented May 12, 2022 •
edited
Loading

Also, the golden tests in plutus-use-cases-test don't fail on my machine when running nix build -f ci.nix linux in a nix-shell

@MaximilianAlgehed
Copy link
Contributor Author

MaximilianAlgehed commented May 12, 2022 •
edited
Loading

And local CI fails with nonsense logs like in the comment below.

@MaximilianAlgehed
Copy link
Contributor Author

MaximilianAlgehed commented May 12, 2022 •
edited
Loading 

ⁱ[nix-shell:~/IOHK/plutus-apps]$ nix log /nix/store/5s7dsljp3ndxykb57az64w8r4j1ncgk5-plutus-use-cases-lib-plutus-use-cases-0.1.0.0.drv
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/gir9j2bmps079fw6fbvrq98m794hpnz2-plutus-apps-root-plutus-use-cases-lib-plutus-use-cases-root
source root is plutus-apps-root-plutus-use-cases-lib-plutus-use-cases-root
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
Configure flags:
--prefix=/nix/store/v66xnkw7sqjhykkvwz54qaakvrynzz9y-plutus-use-cases-lib-plutus-use-cases-0.1.0.0 lib:plutus-use-cases --package-db=clear --package-db=/nix/store/frfj3nyhww79fdq031pa7mshmizrnn07-plutus-use-cases-lib-plutus-use-cases-0>
Configuring library for plutus-use-cases-0.1.0.0..
Warning: 'hs-source-dirs: scripts' directory does not exist.
Warning: 'hs-source-dirs: test' directory does not exist.
Warning: 'hs-source-dirs: test' directory does not exist.
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Preprocessing library for plutus-use-cases-0.1.0.0..
Building library for plutus-use-cases-0.1.0.0..
[ 1 of 35] Compiling Plutus.Contracts ( src/Plutus/Contracts.hs, dist/build/Plutus/Contracts.o, dist/build/Plutus/Contracts.dyn_o )
[ 2 of 35] Compiling Plutus.Contracts.Auction ( src/Plutus/Contracts/Auction.hs, dist/build/Plutus/Contracts/Auction.o, dist/build/Plutus/Contracts/Auction.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 3 of 35] Compiling Plutus.Contracts.Crowdfunding ( src/Plutus/Contracts/Crowdfunding.hs, dist/build/Plutus/Contracts/Crowdfunding.o, dist/build/Plutus/Contracts/Crowdfunding.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 4 of 35] Compiling Plutus.Contracts.Currency ( src/Plutus/Contracts/Currency.hs, dist/build/Plutus/Contracts/Currency.o, dist/build/Plutus/Contracts/Currency.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 5 of 35] Compiling Plutus.Contracts.ErrorHandling ( src/Plutus/Contracts/ErrorHandling.hs, dist/build/Plutus/Contracts/ErrorHandling.o, dist/build/Plutus/Contracts/ErrorHandling.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 6 of 35] Compiling Plutus.Contracts.Escrow ( src/Plutus/Contracts/Escrow.hs, dist/build/Plutus/Contracts/Escrow.o, dist/build/Plutus/Contracts/Escrow.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 7 of 35] Compiling Plutus.Contracts.Game ( src/Plutus/Contracts/Game.hs, dist/build/Plutus/Contracts/Game.o, dist/build/Plutus/Contracts/Game.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_64-linux-ghc-8.10.4.20210212/libHSplutus-contract-0.1.0.0-3MxmGuYKKhO65LSQhESlCb-ghc8.10.4.20210212.so: undefined symbo>
[ 8 of 35] Compiling Plutus.Contracts.GameStateMachine ( src/Plutus/Contracts/GameStateMachine.hs, dist/build/Plutus/Contracts/GameStateMachine.o, dist/build/Plutus/Contracts/GameStateMachine.dyn_o )

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[10 of 35] Compiling Plutus.Contracts.Governance ( src/Plutus/Contracts/Governance.hs, dist/build/Plutus/Contracts/G>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[11 of 35] Compiling Plutus.Contracts.MultiSig ( src/Plutus/Contracts/MultiSig.hs, dist/build/Plutus/Contracts/Multi>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[12 of 35] Compiling Plutus.Contracts.MultiSigStateMachine ( src/Plutus/Contracts/MultiSigStateMachine.hs, dist/buil>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[13 of 35] Compiling Plutus.Contracts.PingPong ( src/Plutus/Contracts/PingPong.hs, dist/build/Plutus/Contracts/PingP>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[14 of 35] Compiling Plutus.Contracts.Prism.STO ( src/Plutus/Contracts/Prism/STO.hs, dist/build/Plutus/Contracts/Pri>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[15 of 35] Compiling Plutus.Contracts.PubKey ( src/Plutus/Contracts/PubKey.hs, dist/build/Plutus/Contracts/PubKey.o,>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[16 of 35] Compiling Plutus.Contracts.SealedBidAuction ( src/Plutus/Contracts/SealedBidAuction.hs, dist/build/Plutus>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[17 of 35] Compiling Plutus.Contracts.SimpleEscrow ( src/Plutus/Contracts/SimpleEscrow.hs, dist/build/Plutus/Contrac>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[18 of 35] Compiling Plutus.Contracts.Stablecoin ( src/Plutus/Contracts/Stablecoin.hs, dist/build/Plutus/Contracts/S>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[19 of 35] Compiling Plutus.Contracts.Swap ( src/Plutus/Contracts/Swap.hs, dist/build/Plutus/Contracts/Swap.o, dist/>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[27 of 35] Compiling Plutus.Contracts.Tutorial.Escrow ( src/Plutus/Contracts/Tutorial/Escrow.hs, dist/build/Plutus/C>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[28 of 35] Compiling Plutus.Contracts.Tutorial.EscrowStrict ( src/Plutus/Contracts/Tutorial/EscrowStrict.hs, dist/bu>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[29 of 35] Compiling Plutus.Contracts.Uniswap.Types ( src/Plutus/Contracts/Uniswap/Types.hs, dist/build/Plutus/Contr>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>
[35 of 35] Compiling Plutus.Contracts.Vesting ( src/Plutus/Contracts/Vesting.hs, dist/build/Plutus/Contracts/Vesting>

<no location info>: error:
    <command line>: /nix/store/zpr3k8d85l8gnz1zwm807z8di72l2bwr-plutus-contract-lib-plutus-contract-0.1.0.0/lib/x86_>

@MaximilianAlgehed
Copy link
Contributor Author

@michaelpj do you mind restarting hydra here?

@michaelpj
Copy link
Contributor

done

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-ContractModel-polish branch from dccd812 to e33649a Compare May 30, 2022 12:15
@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher do you mind merging this?

@sjoerdvisscher sjoerdvisscher merged commit 83594e4 into IntersectMBO:main May 31, 2022
@sjoerdvisscher
Copy link
Contributor

sjoerdvisscher commented May 31, 2022 •
edited
Loading

Finally a real green PR again! (By the way, I did look at this yesterday, but since your last commit was "wip" I wasn't expecting it to be finished!)

@UlfNorell UlfNorell deleted the PR-ContractModel-polish branch May 31, 2022 08:30
@MaximilianAlgehed
Copy link
Contributor Author

Oops, I think it was wip because I have a git alias 😅

wip = !(git commit -am wip || git commit -am wip) && git push

koslambrou pushed a commit that referenced this pull request Jun 22, 2022
@MaximilianAlgehed @koslambrou
ContractModel: Report symbolic values as their symbolic names (#452)
382ab46 
* Report symbolic values as their symbolic names

* fix build issue in tutorial

* update golden test

* wip

* fix build issues

* dependencies

* update golden test

* wip
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximilianAlgehed @sjoerdvisscher @michaelpj