This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
SCP-3331 Fixed error handling for transaction balancing in PAB. #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cardano.Wallet.LocalClient.runClient'
function erroneously rethrows errors it catches instead of returning them viapure . Left
, as required by its type signature. The errors are not handled and end up killing the thread that handles the contract instance. This change successfully passes the Marlowe test https://github.com/input-output-hk/marlowe-cardano/blob/sprint-52/marlowe-cli/test/test-wallet-failure.yaml.(In general, I recommend reviewing the PAB codebase for similar re-throwing problems and for
forkIO
s that aren't guarded against its thread dying because of an uncaught exception.)Pre-submit checklist: