This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
ContractModel: Test that slot numbers line up between model and emulator #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and improve showing wallets.
|
@sjoerdvisscher Do you think that the changes to the mock wallets we have here make sense? Before we had the problem that in the test you would write stuff like "do x for wallet 1" and "wallet 1" would show up as |
sjoerdvisscher
approved these changes
Mar 1, 2022
bwbush
pushed a commit
that referenced
this pull request
Mar 11, 2022
…tor (#327) * Test that slot numbers line up between model and emulator and improve showing wallets. * fixes to PAB after mock wallet change + refactor PAB emulator to be marginally safer * more fixes * fix purs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And improve how we show mock wallets in the emulator.
Pre-submit checklist: