Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

SCP-3501: Remove txs from chain index #315

Merged
17 commits merged into from
Feb 22, 2022
Merged

SCP-3501: Remove txs from chain index #315

17 commits merged into from
Feb 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 16, 2022

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@ghost ghost changed the title Remove txs from chain index SCP-3501: Remove txs from chain index Feb 18, 2022
@ghost ghost marked this pull request as ready for review February 18, 2022 10:18
@ghost ghost requested a review from koslambrou February 18, 2022 10:20
Copy link
Contributor

@koslambrou koslambrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. However, I would also add a property test to ensure this works as expected. Here's an idea.

In HandlerSpec, you can add a property test which:

  • calls appendBlock
  • for all possibles addresses (or at least one address), call utxoSetAtAddress
  • Then call getUtxoutFromRef for each utxo
  • Verify the result is not Nothing

@ghost ghost requested a review from koslambrou February 22, 2022 08:40
Evgenii Akentev added 2 commits February 22, 2022 15:13
@ghost ghost merged commit 65220a0 into main Feb 22, 2022
@ghost ghost deleted the remove-txs-chain-index branch February 22, 2022 12:10
@koslambrou koslambrou restored the remove-txs-chain-index branch April 13, 2022 19:12
@ghost ghost deleted the remove-txs-chain-index branch April 22, 2022 12:07
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant