Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

ContractModel: add assertSpec operation #311

Merged
merged 1 commit into from
Feb 14, 2022
Merged

ContractModel: add assertSpec operation #311

merged 1 commit into from
Feb 14, 2022

Conversation

MaximilianAlgehed
Copy link
Contributor

@MaximilianAlgehed MaximilianAlgehed commented Feb 10, 2022 •
edited
Loading

This adds the ability to assert properties directly in the ContractModel specifications.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-minor-quickcheck-improvements branch from 1550c82 to dfcd45b Compare February 10, 2022 10:33
@MaximilianAlgehed
Copy link
Contributor Author

MaximilianAlgehed commented Feb 10, 2022 •
edited
Loading

@sjoerdvisscher could you have a quick look at this? (If you do, please wait until after I've marked it as ready again - I forgot something and now I'm waiting for nix-shell to restart...)

@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft February 10, 2022 12:47
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-minor-quickcheck-improvements branch from dfcd45b to c9ea267 Compare February 10, 2022 13:08
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review February 10, 2022 13:08
@MaximilianAlgehed MaximilianAlgehed marked this pull request as draft February 10, 2022 13:16
@MaximilianAlgehed MaximilianAlgehed force-pushed the PR-minor-quickcheck-improvements branch from c9ea267 to c4b1c78 Compare February 10, 2022 13:24
@MaximilianAlgehed MaximilianAlgehed marked this pull request as ready for review February 10, 2022 13:34
@MaximilianAlgehed
Copy link
Contributor Author

Can we have the Hydra build for this restarted perhaps?

sjoerdvisscher
sjoerdvisscher approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be a bit more descriptive in the PR title? I feel like we've had quite a few "contractmodel improvement" PRs now.

@MaximilianAlgehed MaximilianAlgehed changed the title Simple ContractModel improvement ContractModel: adding `assertSpåe Feb 14, 2022
@MaximilianAlgehed MaximilianAlgehed changed the title ContractModel: adding `assertSpåe ContractModel: add assertSpec operation Feb 14, 2022
@MaximilianAlgehed
Copy link
Contributor Author

Done! :)

@sjoerdvisscher sjoerdvisscher merged commit 7f543e2 into IntersectMBO:main Feb 14, 2022
@MaximilianAlgehed MaximilianAlgehed deleted the PR-minor-quickcheck-improvements branch February 16, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximilianAlgehed @sjoerdvisscher