This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
SCP-3343 fixed intermittent rollback failures in PAB #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cause of the rollback failure was that `Plutus.ChainIndex.UtxoState.rollbackWith` computes the current tip of the index as the slot of the last transaction, ignoring the fact that there may be empty blocks after that. When a rollback with a target falls within such a sequence of empty blocks, the rollbackWith function misinterprets this as a TipMismatch. This change simply checks to see if the rollback is unnecessary because it is through a sequence of empty blocks ending at the former tip.
sjoerdvisscher
approved these changes
Feb 9, 2022
raduom
approved these changes
Feb 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the rollback failure was that
Plutus.ChainIndex.UtxoState.rollbackWithcomputes the current tip of the index as the slot of the last transaction, ignoring the fact that there may be empty blocks after that. When a rollback with a target falls within such a sequence of empty blocks, therollbackWithfunction misinterprets this as aTipMismatch.This change simply checks to see if the rollback is unnecessary because it is
through a sequence of empty blocks ending at the former tip.
This was manually tested on the private Marlowe testnet, where we verified that rollback failures no long occur when they just rollback through empty blocks.
Pre-submit checklist: