Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Smart shrinking for state machine tests #262

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Smart shrinking for state machine tests #262

merged 3 commits into from
Jan 20, 2022

Conversation

MaximilianAlgehed
Copy link
Contributor

This fixes an issue that caused quadratic times for QuickCheck shrinking of ContractModels.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@MaximilianAlgehed
Copy link
Contributor Author

@sjoerdvisscher Do you mind taking a quick look at this? It's a tiny change :)

sjoerdvisscher
sjoerdvisscher approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!

@sjoerdvisscher sjoerdvisscher merged commit 7905488 into IntersectMBO:main Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sjoerdvisscher sjoerdvisscher sjoerdvisscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximilianAlgehed @sjoerdvisscher