This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
SCP-3216 psgenerator and PAB compatibility with Marlowe #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `plutus-pab-executables.cabal` file names the library `plutus-pab-psgenerator`, which works fine within that package, but it prevents either nix or cabal builds that use this library.
ghost
requested a review
from
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two blocking issues for Marlowe:
ExportTx, which was previously omitted. The closure of purescript types was incomplete without this.pab-executables.cabalno longer contains a non-standard named libraryplutus-pab-psgenerator. The non-standard library name had prevented external use of the library via eithercabalornix-build. (Just renaming the library seemed preferable to renaming the folder. Note that thecabalversion constraint did not allow non-standard library names.)These changes were tested in marlowe-lang/marlowe-cardano#57. It was not possible to test fully in
plutus-appsbecausenix-buildin the root folder previously fails there.Pre-submit checklist: