Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Add the rollback history command line option. #191

Merged
merged 9 commits into from
Dec 21, 2021

Conversation

raduom
Copy link
Contributor

@raduom raduom commented Dec 13, 2021

Provide a --rollback-history INT and a configuration setting for the PAB Webserver (named rollbackHistory) that controls how much history we retain for rollbacks.

If you don't need to test rollbacks, then setting the rollback-history to a lower value (I tested with 500) will greatly limit the amount of RAM that the PAB will consume. A value of 0 turns off this feature.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@raduom raduom force-pushed the raduom/rollback-history branch from 1fd924d to 47a805c Compare December 15, 2021 15:14
@raduom raduom marked this pull request as ready for review December 16, 2021 07:00
@raduom raduom self-assigned this Dec 16, 2021
@raduom raduom requested a review from silky December 16, 2021 07:04
@raduom
Copy link
Contributor Author

raduom commented Dec 16, 2021

I just thought of moving the option into a new Development section as this and the one in the next PR should probably not be used in production.

@raduom raduom force-pushed the raduom/rollback-history branch from d886292 to 512714c Compare December 18, 2021 05:06
@raduom raduom force-pushed the raduom/rollback-history branch from 8d63b05 to 5998d7b Compare December 18, 2021 07:02
@raduom raduom force-pushed the raduom/rollback-history branch from 1a7a56c to a8d3430 Compare December 20, 2021 20:12
@raduom raduom merged commit 5f59fc6 into IntersectMBO:main Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants