This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
Add the rollback history command line option. #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1fd924d
to
47a805c
Compare
I just thought of moving the option into a new |
sjoerdvisscher
suggested changes
Dec 16, 2021
d886292
to
512714c
Compare
8d63b05
to
5998d7b
Compare
1a7a56c
to
a8d3430
Compare
silky
approved these changes
Dec 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a
--rollback-history INT
and a configuration setting for the PAB Webserver (namedrollbackHistory
) that controls how much history we retain for rollbacks.If you don't need to test rollbacks, then setting the rollback-history to a lower value (I tested with
500
) will greatly limit the amount of RAM that the PAB will consume. A value of0
turns off this feature.Pre-submit checklist: