This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
SCP-3130: Tx constraint to specify stake stake key hash with payment #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
commented
Dec 9, 2021
Comment on lines
+67
to
+75
| {-# INLINABLE pubKeyHashAddress #-} | ||
| -- | The address that should be targeted by a transaction output locked by the | ||
| -- given public payment key (with it's public stake key). | ||
| -- | ||
| -- TODO: This should be moved to Plutus.V1(or V2).Ledger.Address with the newtypes. | ||
| pubKeyHashAddress :: PaymentPubKeyHash -> Maybe StakePubKeyHash -> Address | ||
| pubKeyHashAddress (PaymentPubKeyHash pkh) skh = | ||
| Address (PubKeyCredential pkh) | ||
| (fmap (StakingHash . PubKeyCredential . unStakePubKeyHash) skh) |
There was a problem hiding this comment.
@michaelpj This was copied from plutus because it's own pubKeyHashAddress would set the stake credential to Nothing. Is it okay if modify that function on the plutus side? V1 or V2?
There was a problem hiding this comment.
Yeah, fine to modify it, it's not used by the key bit.
koslambrou
force-pushed
the
scp-3130-mustPayToAddress
branch
5 times, most recently
from
4dca821 to
885c6df
Compare
…e stake public key hash of a transaction output address. * Added the constraints `mustPayToPubKeyAddress` and `mustPayWithDatumToPubKeyAddress` * Added newtype wrappers to differentiate between public key hashes: `PaymentPubKeyHash`, `PaymentPubKey`, `StakePubKeyHash` and `StakePubKey`. * Added newtype wrapper 'PaymentPrivateKey' * Replaced most `PubKeyHash` and `PubKey` in code with the newly defined newtypes. * Modified the name of `WalletEffect.ownPubKeyHash` to `WalletEffect.ownPaymentPubKeyHash`. * Added the prefix 'mock' to the name of functions in `Wallet.Emulator.Wallet` to refer to Mock wallets. * Formatted the modified modules based on the `-Wmissing-import-lists` GHC flag.
koslambrou
force-pushed
the
scp-3130-mustPayToAddress
branch
from
885c6df to
51ac83f
Compare
silky
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the tx creation constraints (
plutus-ledger-constraintsrepo) to allow to specify the stake public key hash of a transaction output address.This isn't strictly necessary, since you can make payments using only the payment key. However, it is useful when you want to derive a specific Cardano address (bech32 format) which needs the payment key + stake key.
While doing that, I also took the time to add a additionnal newtype wrappers to
PubKeyHashsuch asPaymentPubKeyHash,PaymentPubKey,StakePubKeyHashandStakePubKeyin order to clearly understand to whichPubKeyHashwe are refering to. This implied a lot of code change. These datatypes where defined inLedger.Address.Related to that, I changed the name of
WalletEffect.ownPubKeyHashtoWalletEffect.ownPaymentPubKeyHash. Maybe it also makes sense to also add the effectWalletEffect.ownStakePubKeyHash, but this should be in a separate PR.Pre-submit checklist: