This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Fix mustSatisfyAnyOf logic (fix #101). #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjoerdvisscher
approved these changes
Dec 6, 2021
| @@ -107,7 +108,7 @@ checkTxConstraint ctx@ScriptContext{scriptContextTxInfo} = \case | |||
| $ V.findDatum dvh scriptContextTxInfo == Just dv | |||
| MustSatisfyAnyOf xs -> | |||
| traceIfFalse "Ld" -- "MustSatisfyAnyOf" | |||
| $ any (checkTxConstraint ctx) xs | |||
| $ or $ map (all (checkTxConstraint ctx)) xs | |||
There was a problem hiding this comment.
That's just any (all (checkTxConstraint ctx)) xs isn't it?
ghost
force-pushed
the
fix-mustsatisfyanyof
branch
from
d3bbde0 to
5891f08
Compare
|
Seems fine @ak3n ; but I note that the PIR gets larger, and some of the golden outputs (amounts) change? Is that because the PIR got larger? Is that expected? |
silky
approved these changes
Dec 7, 2021
|
@ak3n I'm happy then if you're happy :) |
add contract test Use any instead of or and map
ghost
force-pushed
the
fix-mustsatisfyanyof
branch
from
5891f08 to
40b63ed
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #101
Pre-submit checklist: