-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove no longer needed workarounds #4907
Conversation
cc52461
to
0f2237b
Compare
0f2237b
to
1c8dc76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for explaining and linking to why they are not needed anymore 👍
A CBOR roundtrip test is failing, as it's not longer true that " Negative Coin succeeds for pre-Conway`, so we could probably just remove it : https://github.com/IntersectMBO/cardano-ledger/blob/lehins/remove-no-longer-needed-hacks/eras/mary/impl/test/Test/Cardano/Ledger/Mary/ValueSpec.hs#L50
1c8dc76
to
2306b96
Compare
2306b96
to
a5a7a6b
Compare
a5a7a6b
to
6d53ad2
Compare
Yep. Removed it. |
Description
This PR removes conditional decoding workarounds that where set in place in order to preserve the behavior of decoders, until we are in newer eras where fix is permanent:
IgnoreSigOrd
, which, until Alonzo, preserved the behavior of olderOrd
instance forWitVKey
. Fixes Attempt removingIgnoreSigOrd
#4902Coin
, which until Conway era allowed negative coin in a couple of obscure places.This change has been verified to have no affect on mainnet, preview and preprod. Therefore removal of those hacks can now be safely removed.
Checklist
CHANGELOG.md
files updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
updated (usescripts/gen-hie.sh
)