Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed workarounds #4907

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 25, 2025

Description

This PR removes conditional decoding workarounds that where set in place in order to preserve the behavior of decoders, until we are in newer eras where fix is permanent:

This change has been verified to have no affect on mainnet, preview and preprod. Therefore removal of those hacks can now be safely removed.

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/remove-no-longer-needed-hacks branch from cc52461 to 0f2237b Compare February 25, 2025 03:18
@lehins lehins marked this pull request as ready for review February 25, 2025 03:19
@lehins lehins requested a review from a team as a code owner February 25, 2025 03:19
@lehins lehins requested a review from teodanciu February 25, 2025 03:20
@lehins lehins force-pushed the lehins/remove-no-longer-needed-hacks branch from 0f2237b to 1c8dc76 Compare February 25, 2025 05:05
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for explaining and linking to why they are not needed anymore 👍

A CBOR roundtrip test is failing, as it's not longer true that " Negative Coin succeeds for pre-Conway`, so we could probably just remove it : https://github.com/IntersectMBO/cardano-ledger/blob/lehins/remove-no-longer-needed-hacks/eras/mary/impl/test/Test/Cardano/Ledger/Mary/ValueSpec.hs#L50

@teodanciu teodanciu force-pushed the lehins/remove-no-longer-needed-hacks branch from 1c8dc76 to 2306b96 Compare February 25, 2025 14:23
@lehins lehins force-pushed the lehins/remove-no-longer-needed-hacks branch from 2306b96 to a5a7a6b Compare February 25, 2025 20:53
@lehins lehins force-pushed the lehins/remove-no-longer-needed-hacks branch from a5a7a6b to 6d53ad2 Compare February 25, 2025 23:52
@lehins lehins enabled auto-merge February 25, 2025 23:53
@lehins
Copy link
Collaborator Author

lehins commented Feb 25, 2025

A CBOR roundtrip test is failing, as it's not longer true that " Negative Coin succeeds for pre-Conway`, so we could probably just remove it

Yep. Removed it.

@lehins lehins merged commit f5b3569 into master Feb 26, 2025
154 checks passed
@lehins lehins deleted the lehins/remove-no-longer-needed-hacks branch February 26, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt removing IgnoreSigOrd Attempt removing conditional translation of certificates
2 participants