-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid deprecated CompoundTag in API #2883
Conversation
Was moving to jetbrains annotations from javax done on purpose? I believe we're relatively consistent for the latter |
JavaX is superseded by Jakarta. A migration away from JavaX is a good choice, whether it's its successor or a replacement. |
Should probably make a decision and move all of them at once imo |
No, it's mostly because IntelliJ likes to use its annotations by default. I switched to javax for now, but we might want to consider switching to jspecify or checkerframework in future. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
54fafe2
to
149cf0d
Compare
Overview
Description
CompoundTag
is deprecated and its implementation is now backed byLinCompoundTag
. This causes significant overhead when access its data due to the needed transformation/copy.This PR aims to address spots where
CompoundTag
is used in FAWE api, as well as some uses that can benefit from the reduced overhead. There is more to do to getCompoundTag
fully out of FAWE, but more changes can be addressed later.Submitter Checklist