feat: schematic share system, add missing Clipboard method for api compat #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow plugins to register new clipboard share destinations * Rename file, as per request * Don't use the base enginehub name for EH_pastebin * Address review comments * Fixed wrong usage * Use a second metadata class for clipboard shares * Newline * Address comments * Improve docs * Apply suggestions from code review Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Use a consumer so that we handle serialization * Update worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/Clipboard.java Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Update worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/share/ClipboardShareDestination.java Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Update worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/share/ShareOutputConsumer.java Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Update worldedit-core/src/main/java/com/sk89q/worldedit/extent/clipboard/io/share/ShareOutputConsumer.java Co-authored-by: Octavia Togami <octavia.togami@gmail.com> * Fixed a lot of random comments * Return a consumer from share rather than a URL, allows the share destination to control output Co-authored-by: Octavia Togami <octavia.togami@gmail.com> (cherry picked from commit 6e2b0a1df8a6077c3cf8193e38dc9817038bcbe9)
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
…cShare # Conflicts: # worldedit-core/src/main/java/com/sk89q/worldedit/internal/util/ClipboardTransformBaker.java
dordsor21
approved these changes
Jun 1, 2024
PierreSchwang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Followup to #2619
Closes #2740
Description
Cherrypicks upstream commit for the remaining schematic sharing system (added the missing method from #2740)
Added arkitektonika as default share endpoint, marked download-deprecation with forRemoval (as there is now an alternative)
Result on share is the following:
(I've tried directly sending the link in chat - but that looked horrendous, to say the least)
Submitter Checklist