FW update test #8487
Merged
FW update test #8487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Mar 8, 2021
maloel
reviewed
Mar 8, 2021
| import pyrealsense2 as rs, sys, os, subprocess, re | ||
| from rspy import devices, log, test | ||
|
|
||
| def filesin( root ): |
There was a problem hiding this comment.
Can't we separate these into another module in rspy?
maloel
reviewed
Mar 8, 2021
| #log.d(leaf) | ||
| yield leaf | ||
|
|
||
| def get_bundled_fw_version( product_line ): |
There was a problem hiding this comment.
Same with this:
Can we create a repo module that would automatically look for the LRS repo root and then would have a function to get the FW version for a product line?
maloel
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.