Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rs-enumerate-devices and libusb handling fixes #5716

Merged
merged 4 commits into from
Feb 4, 2020

Conversation

ev-mp
Copy link
Collaborator

@ev-mp ev-mp commented Jan 26, 2020

rs-enumerate-devices enhancements and fixes:

  • Make the tool more robust to device create failure. Reproduced by running w/o udev-rules applied.
  • Revert -s option to invoke a one-line description per device.
  • Add -S to provide the device node data (used to be -s)
  • Update documentation

libusb fix:

  • Check return value on device open to prevent null de-referencing and segfault. Also applicable to T265 boot.

Addresses #5423

Tracked on: DSO-14190

@maloel maloel self-assigned this Jan 29, 2020
ev-mp added 3 commits February 2, 2020 13:09
… Also applies to T265 boot.

Make rs-enumerate-devices robust to device create failure. Reproduced by running rs-enumerate-devices w/o udev-rules applied
- Handle exception in case device creation fails.
- Introduce `-S` option to present device node info that was previously invoked by `-s` option.
- Revert `-s`  to a one-line device description
@ev-mp ev-mp force-pushed the device_ctor_failure branch from 9dc74af to a10b64d Compare February 2, 2020 13:31
@ev-mp ev-mp changed the title Infrastructure fixes and enhancements rs-enumerate-devices fixes and enhancements Feb 2, 2020
@ev-mp ev-mp changed the title rs-enumerate-devices fixes and enhancements rs-enumerate-devices and libusb handling fixes Feb 3, 2020
@ev-mp ev-mp force-pushed the device_ctor_failure branch from b3f63f5 to 10a248f Compare February 4, 2020 09:37
@ev-mp ev-mp merged commit 84e40c0 into IntelRealSense:development Feb 4, 2020
@ev-mp ev-mp deleted the device_ctor_failure branch February 5, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants