Remove live-test build #13321
Remove live-test build #13321
Conversation
.github/workflows/buildsCI.yaml
Outdated
| @@ -302,8 +302,7 @@ jobs: | |||
| continue-on-error: true | |||
| run: | | |||
| export LRS_LOG_LEVEL="DEBUG"; | |||
| cd build/${{env.LRS_RUN_CONFIG}}/ | |||
| ./live-test -d yes -i [software-device] | |||
| cd build/${{env.LRS_RUN_CONFIG}}/ | |||
There was a problem hiding this comment.
@noacoohen, do we need U20_U24_ST_Py_EX_CfU_LiveTest section, if no live tests are ran?
There was a problem hiding this comment.
BTW the name is wrong right? Its U22 U24?
There was a problem hiding this comment.
@Arun-Prasad-V ,This is the only build that compiles Ubuntu with Examples & Tools or with Check for Updates so I didn't remove it
There was a problem hiding this comment.
@Nir-Az, yes, I'll change it
There was a problem hiding this comment.
@noacoohen, okay got it. Then, does it make sense to remove _LiveTest from the name and also remove the Test section if we are not going to test anything?
.github/workflows/buildsCI.yaml
Outdated
| continue-on-error: true | ||
| run: | | ||
| export LRS_LOG_LEVEL="DEBUG"; | ||
| cd build/${{env.LRS_RUN_CONFIG}}/ | ||
|
|
||
| - name: Upload RS log artifact |
There was a problem hiding this comment.
IMO since the test step dropped, we will have no log artifact and this stage can be deleted as well, right?
.github/workflows/buildsCI.yaml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: Log file - ${{ matrix.name }}_ST_Py_EX_CfU_LiveTest | ||
| path: build/${{env.LRS_RUN_CONFIG}}/*.log | ||
|
|
||
| - name: Provide correct exit status for job |
There was a problem hiding this comment.
Sorry but I just noticed the last stage which is also not needed :)
No more tests
Remove remaining code related to legacy-live-tests
Tracked by LRS-1173