Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake build on a root folder that contains spaces #11780

Merged
merged 6 commits into from
May 15, 2023
Merged

Fix CMake build on a root folder that contains spaces #11780

merged 6 commits into from
May 15, 2023

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented May 8, 2023

Tracked on [LRS-779]

@Tamir91 Tamir91 requested a review from Nir-Az May 8, 2023 11:09
@Tamir91 Tamir91 added the python label May 8, 2023
@Tamir91 Tamir91 removed the request for review from Nir-Az May 8, 2023 11:10
@Nir-Az Nir-Az requested a review from OhadMeir May 11, 2023 08:43
@Nir-Az Nir-Az changed the title Fixing bug space in link in Cmake file Fix CMake build on a root folder that contains spaces May 11, 2023
@Tamir91 Tamir91 requested a review from Nir-Az May 11, 2023 08:50
Nir-Az
Nir-Az approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's also have @OhadMeir inputs

@Nir-Az
Copy link
Collaborator

Nir-Az commented May 14, 2023

@OhadMeir ?

@OhadMeir
Copy link
Contributor

@OhadMeir ?

I tried it on Thursday and it did not work but could not share screen with Tamir due to technical issues. Will continue with him tomorrow.

@Tamir91 @OhadMeir
bug fixed
268a017 
We found one bug with Cmake that was fixed by adding a small change.

Co-Authored-By: Ohad Meir <100071798+OhadMeir@users.noreply.github.com>
OhadMeir
OhadMeir approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works OK now

@Nir-Az Nir-Az merged commit 0be8984 into IntelRealSense:development May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tamir91 @Nir-Az @OhadMeir