support for Python 3.11 with pybind11 v2.10.3 #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run RealCI and verify no repression with the new pybind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with https://github.com/IntelRealSense/librealsense-deploy/pull/125 and https://github.com/IntelRealSense/librealsense_win_installer/pull/18.
Adding 3.11 (with new pybind11) causes crashes in 3.6 (in
gil_scoped_acquire). Certain changes were made to the GIL stuff post-3.6. I tried debugging but any changes on our part would take a lot of testing and I'm not sure are warranted. 3.6 is already EOL.With the new pybind11, running on 3.7+ passes libCI.
Tracked on [LRS-601]