Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12033] Restructure native Directory #933

Merged
merged 3 commits into from
Mar 2, 2023
Merged

[MOB-12033] Restructure native Directory #933

merged 3 commits into from
Mar 2, 2023

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Feb 28, 2023

Description of the change

  • Rename all src/native/ExampleNativeModule.ts to src/native/NativeExample.ts.
  • Move the NativeExample object to its src/native/NativeExample.ts instead of src/native/index.ts.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Feb 28, 2023
@a7medev a7medev changed the base branch from master to dev February 28, 2023 13:51
@TheBuggedYRN TheBuggedYRN changed the title [MOB-12033] Restructure Native Directory [MOB-12033] Restructure native Directory Mar 1, 2023
TheBuggedYRN
TheBuggedYRN suggested changes Mar 1, 2023
View reviewed changes
@a7medev a7medev requested a review from TheBuggedYRN March 1, 2023 13:51
TheBuggedYRN
TheBuggedYRN previously approved these changes Mar 1, 2023
View reviewed changes
Base automatically changed from dev to master March 1, 2023 15:24
@a7medev a7medev force-pushed the refactor/restructure-native branch from 18da13f to 39c9caa Compare March 1, 2023 15:40
@a7medev a7medev changed the base branch from master to dev March 1, 2023 15:42
@a7medev a7medev requested a review from TheBuggedYRN March 1, 2023 15:42
@a7medev a7medev merged commit ec1f130 into dev Mar 2, 2023
@a7medev a7medev deleted the refactor/restructure-native branch March 2, 2023 08:38
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@a7medev @HeshamMegid
[MOB-12033] Restructure native Directory (#933)
cffd14d 
* Restructure Native Directory

* Remove commented code

* Fix imports in mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBuggedYRN TheBuggedYRN TheBuggedYRN approved these changes

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

Assignees

@a7medev a7medev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a7medev @TheBuggedYRN