Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate release post check job #1305

Conversation

AyaMahmoud148
Copy link

@AyaMahmoud148 AyaMahmoud148 commented Oct 31, 2024

Description of the change

  1. Packed the sdk to be use as npm package instead of linking with source code
  2. add the package to the hybrid app
  3. Build the hybrid app with the SDK package to make sure that everything is oki

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

https://instabug.atlassian.net/browse/MOB-16270

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Oct 31, 2024

Coverage Report

Label Coverage Status
JavaScript 98.4%
Android 50.2%
iOS 49.4%

Generated by 🚫 dangerJS against f066ba8

Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @AyaMahmoud148! I've got some comments, please check them out, I'd love to hear your thoughts.

@AyaMahmoud148 AyaMahmoud148 requested a review from a7medev October 31, 2024 10:07
@AyaMahmoud148 AyaMahmoud148 force-pushed the chore/validate-release-post-check-job branch from 49580f8 to aea4f53 Compare October 31, 2024 10:55
@AyaMahmoud148 AyaMahmoud148 marked this pull request as draft October 31, 2024 12:51
@AyaMahmoud148 AyaMahmoud148 requested a review from a7medev November 2, 2024 01:05
@AyaMahmoud148 AyaMahmoud148 marked this pull request as ready for review November 2, 2024 01:21
@AyaMahmoud148 AyaMahmoud148 changed the title chore: Validate release post check job CI: Validate release post check job Nov 3, 2024
@AyaMahmoud148 AyaMahmoud148 requested a review from a7medev November 3, 2024 11:53
@a7medev a7medev changed the title CI: Validate release post check job ci: validate release post check job Nov 3, 2024
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @AyaMahmoud148! 👏🏼❤️

@AyaMahmoud148 AyaMahmoud148 merged commit 3ca4e81 into feat/enterprise-release-post-checks Nov 4, 2024
15 of 17 checks passed
@AyaMahmoud148 AyaMahmoud148 deleted the chore/validate-release-post-check-job branch November 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants