Handling for when scr_unit is missing-y #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominic-irx
reviewed
Oct 17, 2024
| @@ -146,7 +146,7 @@ calc_egfr <- function ( | |||
| } | |||
|
|
|||
| # ---- Convert Creatinine | |||
| if (is.null(scr_unit)) { | |||
| if (is.null(scr_unit) || length(scr_unit) == 0 || all(is.na(scr_unit))) { | |||
There was a problem hiding this comment.
is scr_unit a vector? is.null(scr_unit) would be FALSE if scr_unit = c(NULL, "mg/dL")
There was a problem hiding this comment.
true, but it would be caught in the next line and return an error about unrecognized units, which seems okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the change I made in #63,
convert_creat_unitwould error ifscr_unitwas a vector of length 0:This PR adds additional error handling, falling back to the same default as a NULL scr_unit in the case of a vector of length 0 or where all supplied values are NA.