Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issues #2031 , #2024 and #2011 #2046

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

kdroidFilter
Copy link
Contributor

@kdroidFilter kdroidFilter commented Nov 4, 2024

Resolved issues #2031 , #2024 and #2011 by integrating the benasher44/uuid library to generate UUIDs for WebAssembly targets.

@kdroidFilter kdroidFilter force-pushed the main branch 6 times, most recently from 257ec16 to 76803ac Compare November 4, 2024 08:22
…g the benasher44/uuid library to generate UUIDs for WebAssembly targets.
@kdroidFilter kdroidFilter changed the title Resolved issues #2031 and #2024 Resolved issues #2031 , #2024 and #2011 Nov 4, 2024
@arnaudgiuliani arnaudgiuliani added this to the 4.0.1 milestone Nov 6, 2024
@arnaudgiuliani
Copy link
Member

Weird that it's not working on wasmJs. It'(s from the kotlin stdlib 🤔

@kdroidFilter
Copy link
Contributor Author

Yes I know but yet it is the case... I am not the only one to have had this problem, it has been listed 3 times

@arnaudgiuliani
Copy link
Member

sure, ok. For js let's make the trick 👍

@arnaudgiuliani arnaudgiuliani merged commit 84d8a67 into InsertKoinIO:main Nov 15, 2024
6 checks passed
@CLOVIS-AI CLOVIS-AI mentioned this pull request Nov 18, 2024
@qurbonzoda
Copy link

I would greatly appreciate if you could file an issue for Kotlin with the description of the problem.
We will try to fix it ASAP.

@ApoloApps
Copy link

ApoloApps commented Nov 19, 2024

@qurbonzoda i dont think it is fixable in non https environments
Mozilla Random UUID https access

It seems like it is required to use https or localhost to access Uuid.random() on wasmJs: https://stackoverflow.com/a/77981051
Originally posted by @artemyto in #2024 (comment)

@qurbonzoda
Copy link

Uuid.random() in WasmJs now uses crypto.getRandomValues() under the hood, which does not require a secure context: JetBrains/kotlin@57581ec

The fix will be included in Kotlin 2.1.20.

@arnaudgiuliani
Copy link
Member

Good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants