Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote discover-your-innersource #780

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jeffabailey
Copy link
Contributor

No description provided.

Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes to align the pattern with our pattern template.

Overall I think this is an interesting pattern, that has some way to go before being ready to be published to our book though.

My main concerns right now are:

  • The Solution section contains multiple different things. What are the core aspects of the solution? Maybe we could try to group the bullets into categories, and give each category a distinct name to find out what the overarching themes of the solution are.
  • How is this pattern related to other patterns like InnerSource Portal and Gig Marketplace?
  • Not sure what to do with the "Discussion on" section. this seems more like meeting notes from a discussion that must have happened a long time ago. Maybe we can ask people that are still around if they remember anything about this pattern, like @gruetter and @NewMexicoKid

Besides that, we would have to check the requirements here before publishing to the book: Contributor Handbook - Requirements for maturity 'Structured'

If the ambition here is to have a better version of this pattern merged into our repo, I would recommend to leave this in the Initial state (and folder) for a bit longer. This would allow us to make some fixes and merge these PRs faster.

If the ambition is to get this pattern live in our book, then we will have to invest quite some work here and keep the PR open for a while.

Either way is fine with me, I just want to prevent frustrations as I don't know what your expectations are here.

@spier
Copy link
Member

spier commented Mar 4, 2025

Btw @jeffabailey if you want to use this pattern as a way to learn what it takes to get a pattern ready for publication in the book, by all means, keep pushing :) Just it might not be the easiest path on this particular pattern, as the current content of the pattern leaves a lot of room for improvement.

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Mar 4, 2025
@jeffabailey
Copy link
Contributor Author

I pushed some changes to align the pattern with our pattern template.

Awesome, thank you!

If the ambition is to get this pattern live in our book, then we will have to invest quite some work here and keep the PR open for a while.

This, TBH! :)

Just it might not be the easiest path on this particular pattern, as the current content of the pattern leaves a lot of room for improvement.

Sounds like a great challenge and learning opportunity.

I'll read through more of the published patterns to align this one closer to the others.

I was having a conversation with @rrrutledge about what constitutes an approachable and useful pattern.

The patterns listed on the fearless change website are an interesting overlay to the patterns.

https://fearlessjourney.info/fearless-change-patterns/

I really like "Discover Your InnerSource" name for the pattern.

What do you think about the name?

How is this pattern related to other patterns like InnerSource Portal and Gig Marketplace?

Another great question to answer after defining the appropriate name and scope for this pattern.

## Resulting Context

* Internal components are easily visible
* Developers looking for code can search for it and find it quickly.
* Developers are now looking internally for software components
* Search results are combined (internal and external)
* Process changes, establishing a common communications channel, and encouraging and rewarding owners of reusable code to use the same search engine can contribute to changing the corporate culture. Transformation begins from the grassroots but requires strategic involvement of thought leaders.
* See [Improved Findability](improve-findability.md) (aka Poor Naming Conventions or Badly Named Piles) as a related pattern.
* See [Improved Findability](../1-initial/improve-findability.md) (aka Poor Naming Conventions or Badly Named Piles) as a related pattern.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spier do we generally omit links to initial patterns?

I see one link to an initial pattern here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we would only link to same maturity or higher.

ie omit this link.

## Resulting Context

* Internal components are easily visible
* Developers looking for code can search for it and find it quickly.
* Developers are now looking internally for software components
* Search results are combined (internal and external)
* Process changes, establishing a common communications channel, and encouraging and rewarding owners of reusable code to use the same search engine can contribute to changing the corporate culture. Transformation begins from the grassroots but requires strategic involvement of thought leaders.
* See [Improved Findability](improve-findability.md) (aka Poor Naming Conventions or Badly Named Piles) as a related pattern.
* See [Improved Findability](../1-initial/improve-findability.md) (aka Poor Naming Conventions or Badly Named Piles) as a related pattern.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Findability to vale, or use discoverability?

https://github.com/InnerSourceCommons/isc-styles/blob/main/ISC/styles/config/vocabularies/ISC_General/accept.txt

Recommend using discoverability if we keep this link in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would opt for "discoverability".

* Comments may appear in the timeline but not with the file once it is edited (github)?
* https://github.com/InnerSourceCommons/InnerSourcePatterns/pull/60
* If only X knew what X knew; the internal search engine is bad. No one can find anything because it is difficult to add things to the search index.
* We have similar challenges getting data sources pulled into the search engine. PayPal is building a project called Agora to do this and they are planning to open source it.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danese is Agora a project at PayPal?

It looks like maybe yes? https://www.bis.org/about/bisih/topics/fmis/agora.htm

* Don't bother looking
* Find it Inside

## Discussion on
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spier move this discussion section here and link to it from this PR?

https://github.com/InnerSourceCommons/InnerSourcePatterns/discussions

@jeffabailey jeffabailey requested a review from spier April 2, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants