Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(30-day-warranty): SAP known instance teaser #679

Merged
merged 2 commits into from
Apr 8, 2024
Merged

feat(30-day-warranty): SAP known instance teaser #679

merged 2 commits into from
Apr 8, 2024

Conversation

michael-basil
Copy link
Contributor

@spier @dellagustin - Teaser proposal as requested from #672

@spier spier added 2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns. labels Apr 8, 2024
spier
spier reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are on a roll @michael-basil ! :)

I made some wording suggestions to make it more similar to the other Known Instance descriptions that we have. And sorry about the confusion that I created by using the term "teaser" before, as I think that sent you down on a wrong path.

If you have happy with my suggestion you can integrate it, and then I can merge this PR later today.

@spier spier mentioned this pull request Apr 8, 2024
Merged
@spier
fix(30-day-warranty): Synergize SAP known instance
7606149 
Co-authored-by: Sebastian Spier <github@spier.hu>
@michael-basil
Copy link
Contributor Author

Hi @spier,

Thanks for smoothing this out. Looks and sounds great.

Each step is not the destination, but another step on the path.

This is how I consider learning in general. So for my children learning to write, or a software engineer learning a new language, we have incomplete and mistaken understanding as we begin.

There's always more refactoring that can be done!

Thanks for the guidance.

Warmly.
🌿

@spier spier merged commit a99a4d6 into InnerSourceCommons:main Apr 8, 2024
9 checks passed
@spier
Copy link
Member

spier commented Apr 8, 2024

These changes are now live:
https://patterns.innersourcecommons.org/p/30-day-warranty#known-instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner

@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner

@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner

@yuhattor yuhattor Awaiting requested review from yuhattor yuhattor is a code owner

Assignees
No one assigned
Labels
2-structured Patterns with existing instances (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🐅 patterns-in-the-wild InnerSource patterns that were spotted in the wild. We can extract Known Instances and new patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-basil @spier