Skip to content

Fix: name must not contain dots #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Aug 7, 2024

What this PR does / why we need it

Once name contains dots, it will fail to create Pods.

Which issue(s) this PR fixes

Fixes #67

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@kerthcet
Copy link
Member Author

kerthcet commented Aug 7, 2024

/lgtm
/approve

@kerthcet
Copy link
Member Author

kerthcet commented Aug 7, 2024

/kind bug

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2024
@InftyAI-Agent InftyAI-Agent added bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 7, 2024
Signed-off-by: kerthcet <kerthcet@gmail.com>
@InftyAI-Agent InftyAI-Agent removed the lgtm Looks good to me, indicates that a PR is ready to be merged. label Aug 7, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Aug 7, 2024

/lgtm

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Aug 7, 2024
@InftyAI-Agent InftyAI-Agent merged commit dabd450 into InftyAI:main Aug 7, 2024
19 checks passed
@kerthcet kerthcet deleted the refactor/readme branch August 7, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Once name containers dot, failed to create Pods
2 participants