Skip to content

[1/N] Add backendRuntime CRD #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2024
Merged

[1/N] Add backendRuntime CRD #138

merged 2 commits into from
Sep 10, 2024

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Sep 10, 2024 •
edited
Loading

What this PR does / why we need it

For expandability and easy integration, right now, people can add a new backend without modifying the controller logcis.

Which issue(s) this PR fixes

Part of #134

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add BackendRuntime CRD for expandability

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 10, 2024
@kerthcet
Copy link
Member Author

/kind feature
/kind api-change
/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. api-change Indicates PR includes api change. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Sep 10, 2024
@kerthcet
Copy link
Member Author

/retest

@kerthcet
[1/N] Add backendRuntime CRD
10f01e8 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
Chagne Playground backendConfig to backendRuntimeConfig
b11df31 
Signed-off-by: kerthcet <kerthcet@gmail.com>
@InftyAI-Agent InftyAI-Agent removed the lgtm Looks good to me, indicates that a PR is ready to be merged. label Sep 10, 2024
@kerthcet
Copy link
Member Author

/lgtm

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Sep 10, 2024
@InftyAI-Agent InftyAI-Agent merged commit 49009ae into InftyAI:main Sep 10, 2024
19 checks passed
@kerthcet kerthcet deleted the feat/backendRuntime branch September 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kerthcet kerthcet

Labels
api-change Indicates PR includes api change. approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerthcet @InftyAI-Agent