Android #3
Merged
Android #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Illu
requested changes
Feb 16, 2019
There was a problem hiding this comment.
This is great ! 😄 Thank you for submitting this PR and for the detailed explanation of your changes, this is awesome 😎
I really liked what you did with keeping the current PushNotificationIOS on iOS 👍.
I added some comments to your changes, when trying the app on Android I noticed that the notification toggle wasn't working. Other than that, it's just me nit-picking on minor things 😊.
I noticed some layout issues with the App on Android, but those will get fixed later.
This PR is part of #2
Illu
approved these changes
Feb 17, 2019
|
Awesome ! Thanks @brannonjames, this is very helpful ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a couple tweaks to work run on Android. Basically what this PR does did:
https://github.com/react-native-community/jsc-android-buildscripts#how-to-use-it-with-my-react-native-app
https://github.com/zo0r/react-native-push-notification
I don't have an Apple developers license yet, so I couldn't test react-native-push-notification on iOS and ended up just keeping PushNotificationIOS for those devices.
This is my first PR for an open source project, constructive feedback is welcome :)