Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out the condition for skipping login #376

Merged
merged 2 commits into from
May 29, 2023

Conversation

CamLamb
Copy link
Contributor

@CamLamb CamLamb commented May 12, 2023

The LoginView class has a get method that begins with some logic to determine if the login form should be presented to the current user. If someone wants to override this logic, they have to override the whole get method.

This PR separates the conditions into an overridable method so the get method can focus on building the login form/page.

@peppelinux
Copy link
Member

It good look, thank you @jafacakes2011 !

Can I ask you also to increase the version here
https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30

up to 1.5.8?
Then I'll do tests and we'll have a brand new release thank to you :-)

1 similar comment
@peppelinux
Copy link
Member

It good look, thank you @jafacakes2011 !

Can I ask you also to increase the version here
https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30

up to 1.5.8?
Then I'll do tests and we'll have a brand new release thank to you :-)

@CamLamb
Copy link
Contributor Author

CamLamb commented May 15, 2023

Thanks @peppelinux!
I've bumped the package version as requested 😄

@CamLamb
Copy link
Contributor Author

CamLamb commented May 24, 2023

Hi @peppelinux, just nudging on this to see if we can get it merged 😄

@peppelinux peppelinux merged commit fb5554c into IdentityPython:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants