Improve wording in definition of bootstrap resampling #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Apr 5, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
Merged! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> c393a00
ArturoAmorQ
commented
Apr 5, 2022
Comment on lines
+86
to
+89
| # Bootstrapping is a resampling "with replacement" of the original | ||
| # dataset. It corresponds to sampling n out of n data points with | ||
| # replacement uniformly at random from the original dataset. n is the | ||
| # number of data points in the original dataset. |
There was a problem hiding this comment.
Suggested change
| # Bootstrapping is a resampling "with replacement" of the original | |
| # dataset. It corresponds to sampling n out of n data points with | |
| # replacement uniformly at random from the original dataset. n is the | |
| # number of data points in the original dataset. | |
| # Given a dataset with `n` data points, bootstrapping corresponds | |
| # to resampling "with replacement" `n` out of such `n` data points | |
| # uniformly at random. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this forum post, the wording we use for the definitions of bootstrapping and bootstrap samples can be clearer.
Here is a first approach of a better wording, but feedback is always welcome.