Fix argument passing in the Windows run.bat script. #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows has a peculiar way of interpreting quotes in command line arguments: if the opening quote is not at the beginning of the argument, then it is deemed to be part of the argument. That is, with ARGUMENT='something' the ARGUMENT variable is assigned a value of 'something', *including* the quotes. To make sure the quotes are only used, well, for quoting, and do not end up in the assigned value, the opening quote must be the first character of the argument, as in: 'ARGUMENT=something' This results in ARGUMENT being correctly assigned the value something, *without* quotes. closes #583
|
WOW that was it? You tested it on a windows machine? |
|
I got temporary access to a Windows machine and I could at least test that the shell does behave as described, which makes me pretty confident this is the cause of #583. I did not test the ODK itself on that machine, though – I though it would have been rude to install the ODK on a machine that a friend let me use after I asked him “can I quickly check something on your computer”… :D Unless/until we got someone working on Windows in the team I think this is the best we can do. |
|
No worries I can test it. can be worse than what we had. |
matentzn
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has a peculiar way of interpreting quotes in command line arguments: if the opening quote is not at the beginning of the argument, then it is deemed to be part of the argument.
That is, with
the
ARGUMENTvariable is assigned a value of'something', including the quotes.To make sure the quotes are only used, well, for quoting, and do not end up in the assigned value, the opening quote must be the first character of the argument, as in:
This results in
ARGUMENTbeing correctly assigned the valuesomething, without quotes.closes #583