Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed files that are repeated in obook #578

Merged
merged 4 commits into from
Apr 14, 2022
Merged

Conversation

shawntanzk
Copy link
Contributor

@shawntanzk shawntanzk requested a review from matentzn March 24, 2022 13:59
@shawntanzk shawntanzk self-assigned this Mar 24, 2022
@matentzn
Copy link
Contributor

I know you will kill me shown, but I would prefer if the files stay, their content is deleted and replaced by a link to the corresponding obook page.. :P Sorry.

@shawntanzk
Copy link
Contributor Author

lol I thought you might say that hence me putting the links in the comment so it would be easy to change to that :p I was wondering if it would be smarter to put it in the readme though? I think people coming in would mostly see the readme file

@matentzn
Copy link
Contributor

I am worried users of this will be confused, that is why I think leave the individual pages:

https://ontology-development-kit.readthedocs.io/en/latest/

@shawntanzk
Copy link
Contributor Author

Fair enough, will redo this to redirect each page accordingly then.

@matentzn matentzn marked this pull request as draft April 7, 2022 18:23
@matentzn
Copy link
Contributor

matentzn commented Apr 7, 2022

Converted this to draft while not done, hope ok.

@shawntanzk shawntanzk marked this pull request as ready for review April 14, 2022 10:50
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent man, thank you!

@shawntanzk shawntanzk merged commit e09b6ed into master Apr 14, 2022
@matentzn matentzn added this to the 1.3.1 milestone May 2, 2022
@matentzn matentzn deleted the remove-obook-docs branch December 5, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants