Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OQS encoding as per IETF116 #44

Merged
merged 4 commits into from
May 4, 2023
Merged

OQS encoding as per IETF116 #44

merged 4 commits into from
May 4, 2023

Conversation

baentsch
Copy link
Collaborator

@baentsch baentsch commented Mar 28, 2023

Do not merge until tested!

This PR deposits artefacts using the IETF115 OIDs (except new Falcon OIDs in latest commit) and "classic" OQS key encoding format (as used at IETF115) but using the latest (IETF116) oqs-provider (incl. most current Falcon implementation).

Data re-generation can be done, e.g., by running within the "providers/oqs" directory

docker run -v `pwd`:/ietf -t openquantumsafe/oqs-ossl3:ietf116-hotfix sh -c "apk add bash && cd /ietf && ./gen.sh"

@baentsch
Copy link
Collaborator Author

@ounsworth FYI/testing

@ounsworth
Copy link
Collaborator

@baentsch You have changed:

    runandlog ${dir} falcon512 1.3.9999.3.1
   runandlog ${dir} falcon1024 1.3.9999.3.4

to

   runandlog ${dir} falcon512 1.3.9999.3.6
   runandlog ${dir} falcon1024 1.3.9999.3.9

this change should also be reflected in oid_mapping.md ... I'll do that right now.

@johngray-dev
Copy link
Collaborator

Looks good. Thanks for putting this together Michael and Mike! We had a big discussion on NCCoE about this pull request as well.

Copy link
Collaborator

@johngray-dev johngray-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Michael!

@baentsch baentsch marked this pull request as ready for review May 3, 2023 16:40
@ounsworth ounsworth self-requested a review May 3, 2023 19:14
@johngray-dev johngray-dev merged commit 4bbd8da into master May 4, 2023
@ounsworth ounsworth deleted the mb-ietf-oqs-update branch July 20, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants