-
Notifications
You must be signed in to change notification settings - Fork 23
SCENARIO: Rubrics may include several numerical and alphabetical segm… #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for this scenario @saurL (and anonymous contributors). Please don't forget to fill the copyright agreement with your three names. Please also amend your commit so that your 2 other colleagues get credited for their contribution (e.g. the Regards. |
@saurL @ilonagayda It seems that you have troubles with Git...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @saurL and @ilonagayda.
Please note that your Git history must be cleaned up before being integrated.
Whereas your syntax edits might appear to you as a good idea, they are not: adding unrelated lines in a commit :
- prevents the Git history to be used as a developper documentation (both from a file – with the blame feature – or from the commit graph),
- generates a lot of "false" edition conflicts.
So please:
- "squash" all your implementation commits into a single one (called
FIX: Rubrics may include several numerical and alphabetical segments (fixes #253).
). - With a git visual client (allowing to add or remove code lines in a commit), remove any unrelated lines.
- When everything is OK on your laptop, force push your branch.
If you need help, just ask.
Regards.
@saurL @Odyrac It seems that you dropped the commit structure. You should have two different commits: one for the Please have a look of what your colleagues (@kejaulin, @Lazizzze and @lfcm64) did for the other fix: They can probably help you too if needed. I can also. Just ask. |
We, Ilona gayda, Halley Louisand Lucas, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.