Repair: 在资源路径不存在下error为undefined的情况 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wqcstrong
reviewed
Dec 20, 2023
src/plugins/error.ts
Outdated
Comment on lines
43
to
44
| const defaultMessage = 'An unknown error occurred'; | ||
| const defaultStack = 'No stack trace available'; |
There was a problem hiding this comment.
这两个信息放一起吧，加个前缀: [PageSpy] An unknown error ...
src/plugins/error.ts
Outdated
Comment on lines
46
to
48
| name: '', | ||
| message: defaultMessage, | ||
| stack: defaultStack, |
There was a problem hiding this comment.
ErrorPlugin.sendMessage 的第二个参数 errorDetail 在调试端被用于查看错误信息堆栈、定位源码，字段值期望是标准的 error 信息，这里不适合默认值，可以用 null
|
感谢你的帮助 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在本地接入的项目中引入一个不存在的资源路径地址后抛出错误，此错误应在内部消化掉而不抛出给客户端
修复后的测试用例结果