Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set app icon #95

Closed
2 of 3 tasks
tonsky opened this issue Aug 16, 2021 · 3 comments
Closed
2 of 3 tasks

Set app icon #95

tonsky opened this issue Aug 16, 2021 · 3 comments
Assignees
@tonsky @Alex2772 @EgorOrachyov
Labels
Platform: macOS Platform: Windows Platform: X11
Milestone
Final demo

Comments

@tonsky
Copy link
Collaborator

tonsky commented Aug 16, 2021 •
edited
Loading

TODO: Check AWT & JavaFX

Preliminary:

Window::setIcon(File)

Window::setIcon(byte[])

  • Windows
  • Linux
  • macOS
@tonsky tonsky added this to the Final demo milestone Aug 16, 2021
@i10416
Copy link
Contributor

i10416 commented Aug 22, 2021

Which image fomat should SetIcon(File) function support?

( Windows native api(hIcon) seems to support only .ico format. )

@tonsky
Copy link
Collaborator Author

tonsky commented Aug 23, 2021

We were thinking of whatever native platform expects. That would mean ico for Windows, icns for macOS, not sure what (png?) for Linux

tonsky pushed a commit that referenced this issue Aug 24, 2021
@i10416
add setIcon function for Windows (#95 #126)
87a9967
tonsky added a commit that referenced this issue Aug 24, 2021
@tonsky
Icon files for Windows/macOS/Linux #95
996fc73
tonsky added a commit that referenced this issue Aug 24, 2021
@tonsky
Window::setIcon #95
55e2c79
@tonsky tonsky mentioned this issue Aug 25, 2021
Open
3 tasks
@tonsky
Copy link
Collaborator Author

tonsky commented Aug 25, 2021

Will be followed up by #135

@tonsky tonsky closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonsky tonsky

@Alex2772 Alex2772

@EgorOrachyov EgorOrachyov

Labels
Platform: macOS Platform: Windows Platform: X11
Milestone
Final demo
Development

No branches or pull requests
4 participants
@tonsky @Alex2772 @EgorOrachyov @i10416