Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid some double casts #1347

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Humanizer/Bytes/ByteSize.cs
Original file line number Diff line number Diff line change
Expand Up @@ -330,9 +330,9 @@ public override bool Equals(object value)
}

ByteSize other;
if (value is ByteSize)
if (value is ByteSize size)
{
other = (ByteSize)value;
other = size;
}
else
{
Expand All @@ -359,12 +359,12 @@ public int CompareTo(object obj)
return 1;
}

if (!(obj is ByteSize))
if (obj is ByteSize size)
{
throw new ArgumentException("Object is not a ByteSize");
return CompareTo(size);
}

return CompareTo((ByteSize)obj);
throw new ArgumentException("Object is not a ByteSize");
}

public int CompareTo(ByteSize other)
Expand Down