This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
Hardwire multi_json backend #8574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `multi_json` gem dynamically selects a JSON implementation from a list of candidates. Since we cannot control which gems are installed on a user's machine, this patch hardwires `multi_json` to use the included copy of `ok_json`. `ok_json` is a pure-Ruby JSON encoder/decoder that is bundled with `multi_json`. `ok_json` may not be as fast as other choices, but speed is not critical for our application.
wrigleyster
pushed a commit
to wrigleyster/homebrew
that referenced
this pull request
Nov 17, 2011
The `multi_json` gem dynamically selects a JSON implementation from a list of candidates. Since we cannot control which gems are installed on a user's machine, this patch hardwires `multi_json` to use the included copy of `ok_json`. `ok_json` is a pure-Ruby JSON encoder/decoder that is bundled with `multi_json`. `ok_json` may not be as fast as other choices, but speed is not critical for our application. Closes Homebrew#8574. Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
etehtsea
pushed a commit
to etehtsea/homebrew
that referenced
this pull request
Dec 24, 2011
The `multi_json` gem dynamically selects a JSON implementation from a list of candidates. Since we cannot control which gems are installed on a user's machine, this patch hardwires `multi_json` to use the included copy of `ok_json`. `ok_json` is a pure-Ruby JSON encoder/decoder that is bundled with `multi_json`. `ok_json` may not be as fast as other choices, but speed is not critical for our application. Closes Homebrew#8574. Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
etehtsea
pushed a commit
to etehtsea/homebrew
that referenced
this pull request
Dec 27, 2011
The `multi_json` gem dynamically selects a JSON implementation from a list of candidates. Since we cannot control which gems are installed on a user's machine, this patch hardwires `multi_json` to use the included copy of `ok_json`. `ok_json` is a pure-Ruby JSON encoder/decoder that is bundled with `multi_json`. `ok_json` may not be as fast as other choices, but speed is not critical for our application. Closes Homebrew#8574. Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
The `multi_json` gem dynamically selects a JSON implementation from a list of candidates. Since we cannot control which gems are installed on a user's machine, this patch hardwires `multi_json` to use the included copy of `ok_json`. `ok_json` is a pure-Ruby JSON encoder/decoder that is bundled with `multi_json`. `ok_json` may not be as fast as other choices, but speed is not critical for our application. Closes Homebrew#8574. Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
multi_jsongem dynamically selects a JSON implementation from a list ofcandidates. Since we cannot control which gems are installed on a user's
machine, this patch hardwires
multi_jsonto use the included copy ofok_json.ok_jsonis a pure-Ruby JSON encoder/decoder that is bundled withmulti_json.ok_jsonmay not be as fast as other choices, but speed is notcritical for our application.