Can’t brew upgrade (with no arguments)

[s4y]

When I ran brew upgrade for the first time after updating to cfd9d50, I got this:

==> Upgrading 6 outdated packages, with result:
lame 3.99.1, ffmpeg 0.8.6, gnutls 2.12.14, node 0.6.1, plt-racket 5.2, wireshark 1.7.0
==> Upgrading lame
This command requires a formula argument

brew upgrade lame worked, but now brew upgrade gives me this:

==> Upgrading 5 outdated packages, with result:
ffmpeg 0.8.6, gnutls 2.12.14, node 0.6.1, plt-racket 5.2, wireshark 1.7.0
==> Upgrading ffmpeg
This command requires a formula argument

Any ideas?

[Sharpie]

Ahh... it appears pull request #7784 exposed a weird corner case in ARGV.formulae:

def formulae
  require 'formula'
  @formulae ||= downcased_unique_named.map{ |name| Formula.factory name }
  raise FormulaUnspecifiedError if @formulae.empty?
  @formulae
end

@jacknagel @mxcl @MikeMcQuaid @adamv

Should ARGV.formulae really raise a FormulaUnspecifiedError if it comes up with an empty list? What is wrong with having an empty list?

[Sharpie]

Allright, pushed a hotfix for this.

I still think an empty list is a valid return value for ARGV.formulae and that it shouldn't be throwing exceptions. But that is a cleanup task for another day.