Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a-g]: replace plist with service block #79366

Merged
merged 43 commits into from
Jun 29, 2021

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@SMillerDev SMillerDev changed the title Chore/service/a to g [a-g]: replace plist with service block Jun 15, 2021
@SMillerDev SMillerDev force-pushed the chore/service/a_to_g branch from 44c2747 to 61f8057 Compare June 15, 2021 10:08
@SMillerDev
Copy link
Member Author

==> dig @127.0.0.1 -p 61416 example.com.
dyld: Library not loaded: /opt/homebrew/opt/json-c/lib/libjson-c.5.dylib
  Referenced from: /opt/homebrew/bin/dig
  Reason: image not found

and a checksum mismatch for ejabberd, not bad

@qoega qoega mentioned this pull request Jun 15, 2021
6 tasks
@SMillerDev SMillerDev force-pushed the chore/service/a_to_g branch from 61f8057 to eb62fb6 Compare June 16, 2021 08:52
@SMillerDev
Copy link
Member Author

I don't think any of the errors are related to the service blocks. @Homebrew/core opinions?

@cho-m
Copy link
Member

cho-m commented Jun 23, 2021

  • carrot2 (Big Sur/Catalina) - Did pass when built+tested locally. May need to see if CI environment behaves differently or some other issue.
  • coredns (All) - Previously mentioned. Seems like something odd about running Homebrew's dig (from bind formula?)
    dyld: Library not loaded: /usr/local/opt/json-c/lib/libjson-c.5.dylib
      Referenced from: /usr/local/bin/dig
    
  • ejabberd (All) - Error: SHA256 mismatch
  • fail2ban (Intel) - Unrelated missing build dependency in sphinx-doc (sphinx-doc: restore numpydoc resource for fail2ban build #79892).
  • lanraragi (ARM) - Looks like common test failure seen in other PRs.
  • cntlm (Mojave) - Temporary network issue

@SMillerDev
Copy link
Member Author

I dropped the formulae that were having issues. We can always revisit those later (when cron support is added and we can drop the Plists completely)

@carlocab
Copy link
Member

lanraragi failed on ARM, but that test is flaky (despite my attempts to fix it...). We can probably ignore it.

@SMillerDev SMillerDev force-pushed the chore/service/a_to_g branch from 9ad2d7e to 5065d30 Compare June 28, 2021 06:35
@SMillerDev
Copy link
Member Author

Fails only on ubuntu due to missing dependencies. @carlocab good to merge?

@carlocab
Copy link
Member

Do we need new bottles for this? If yes, unfortunately not: the ARM runner died 19m into the CI run for some reason. If we don't, then I'm fine with merging this.

@SMillerDev
Copy link
Member Author

Nope, it's all in postinstall.

@SMillerDev SMillerDev merged commit 9d20636 into Homebrew:master Jun 29, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants