giflib 5.2.1 #41436

alebcay · 2019-06-28T21:29:50Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Upstream still has not gotten their build system in working order for us with this release, but at least someone was gracious enough to contribute a patch so we can head off to the races with this one. @fxcoudert initiated discussion upstream at https://sourceforge.net/p/giflib/bugs/133/.

alebcay · 2019-06-29T03:01:05Z

mapserver build failure is already happening in current master (probably not caused by this update). Will need to resolve that failure before this can be merged.

SMillerDev · 2019-07-01T19:45:48Z

tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:6701:66: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:CompositingFilter_filter_set", , &arg2)) SWIG_fail;
                                                                 ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7475:59: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:clusterObj_region_set", , &arg2)) SWIG_fail;
                                                          ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7529:65: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:clusterObj_updateFromString", , &arg2)) SWIG_fail;
                                                                ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7626:57: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:clusterObj_setGroup", , &arg2)) SWIG_fail;
                                                        ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7723:58: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:clusterObj_setFilter", , &arg2)) SWIG_fail;
                                                         ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7938:62: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:outputFormatObj_name_set", , &arg2)) SWIG_fail;
                                                             ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:7991:66: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:outputFormatObj_mimetype_set", , &arg2)) SWIG_fail;
                                                                 ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:8044:64: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:outputFormatObj_driver_set", , &arg2)) SWIG_fail;
                                                               ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:8097:67: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:outputFormatObj_extension_set", , &arg2)) SWIG_fail;
                                                                  ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:8412:58: error: expected expression
  if (!PyArg_ParseTuple(args, "O|z:new_outputFormatObj", , &arg2)) SWIG_fail;
                                                         ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9190:66: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:queryMapObj_updateFromString", , &arg2)) SWIG_fail;
                                                                 ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9382:52: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_log_set", , &arg2)) SWIG_fail;
                                                   ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9435:58: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_imagepath_set", , &arg2)) SWIG_fail;
                                                         ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9488:57: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_imageurl_set", , &arg2)) SWIG_fail;
                                                        ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9541:57: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_temppath_set", , &arg2)) SWIG_fail;
                                                        ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9617:57: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_template_set", , &arg2)) SWIG_fail;
                                                        ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9670:55: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_header_set", , &arg2)) SWIG_fail;
                                                      ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9723:55: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_footer_set", , &arg2)) SWIG_fail;
                                                      ^
/tmp/mapserver-20190629-64163-189e4q9/mapserver-7.2.2/build/mapscript/python/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c:9776:54: error: expected expression
  if (!PyArg_ParseTuple(args, "Oz:webObj_empty_set", , &arg2)) SWIG_fail;
                                                     ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
[ 99%] Built target mapserv
[ 99%] Built target shp2img
20 errors generated.
make[2]: *** [mapscript/python/CMakeFiles/_pythonmapscript.dir/CMakeFiles/_pythonmapscript.dir/mapscriptPYTHON_wrap.c.o] Error 1
make[1]: *** [mapscript/python/CMakeFiles/_pythonmapscript.dir/all] Error 2
make: *** [all] Error 2

chenrui333 · 2019-10-03T21:46:17Z

@BrewTestBot test this please

iMichka · 2019-10-10T20:05:25Z

@alebcay This needs to be rebased.

Moisan · 2019-10-15T12:40:27Z

I think the quick fix for mapserver without having to wait on #41884 is to change the swig dependency to swig@3.

Moisan · 2019-11-09T01:01:10Z

pgrouting test is failing and the installation of postgresql as a dependency of mapnik also fails.

fxcoudert · 2019-11-09T13:07:44Z

I think this is good to merge (pgrouting is a common test failure, sadly… unrelated)

fxcoudert · 2019-11-09T13:07:58Z

Thank you @alebcay and @Moisan for your work on this!

fxcoudert · 2019-11-14T09:31:30Z

@BrewTestBot test this please

alebcay · 2019-11-14T14:15:26Z

==> brew test --verbose caffe
==> FAILED
Testing caffe
/usr/bin/sandbox-exec -f /private/tmp/homebrew20191114-41826-69nbna.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/caffe.rb --verbose
==> Downloading http://dl.caffe.berkeleyvision.org/bvlc_reference_caffenet.caffemodel
/usr/bin/curl -q --globoff --show-error --user-agent Homebrew/2.1.16-67-g1b92638\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 10.15\)\ curl/7.64.1 --fail --silent --location --remote-time --continue-at 0 --output /Users/brew/Library/Caches/Homebrew/downloads/b8b2cb12fb8cbc38d1eb301e02486c100e5e7868c1914cd22b3db1e030b806e7--bvlc_reference_caffenet.caffemodel.incomplete http://dl.caffe.berkeleyvision.org/bvlc_reference_caffenet.caffemodel
curl: (7) Failed to connect to dl.caffe.berkeleyvision.org port 80: Operation timed out
Error: caffe: failed
An exception occurred within a child process:
  DownloadError: Failed to download resource "caffe--test_model_weights"
Download failed: http://dl.caffe.berkeleyvision.org/bvlc_reference_caffenet.caffemodel

The model is no longer available at the given URL. dl.caffe.berkeleyvision.org times out, but caffe.berkeleyvision.org is still reachable.

Apart from this error, there's just the usual shmget-related stuff for mapnik and pgrouting.

fxcoudert · 2019-11-14T15:35:38Z

Honestly, this being waiting since June, I suggest we merge as-is, and another PR be opened to deal with the preexisting caffe failure.

SMillerDev · 2019-11-14T20:28:38Z

I'm fine with that too.

SMillerDev added the build failure CI fails while building the software label Jul 1, 2019

alebcay mentioned this pull request Jul 12, 2019

mapserver 7.4.2 #41884

Closed

alebcay force-pushed the giflib-5.2.1 branch from 9475d9d to ea20013 Compare October 10, 2019 21:53

alebcay and others added 11 commits November 8, 2019 09:44

giflib 5.2.1

bedc233

fontforge: bump revision for giflib update

82b6908

gdal: bump revision for giflib update

15eacc1

leptonica: bump revision for giflib update

a099303

libming: bump revision for giflib update

af2d14b

mapserver: bump revision for giflib update

25e6054

openimageio: bump revision for giflib update

0029bd1

pdf2htmlex: bump revision for giflib update

810cf9f

sxiv: bump revision for giflib update

bbc5bfb

xplanet: bump revision for giflib update

8a2a68e

mapserver: use swig@3

bc1432a

Moisan force-pushed the giflib-5.2.1 branch from ea20013 to bc1432a Compare November 8, 2019 14:46

vips: revision bump for giflib update

b464647

fxcoudert added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software labels Nov 9, 2019

SMillerDev removed the ready to merge PR can be merged once CI is green label Nov 14, 2019

fxcoudert closed this in bf4a694 Nov 15, 2019

Bo98 mentioned this pull request Nov 25, 2019

revision bumps for giflib #47141

Closed

lock bot added the outdated PR was locked due to age label Jan 2, 2020

lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

giflib 5.2.1 #41436

giflib 5.2.1 #41436

alebcay commented Jun 28, 2019

alebcay commented Jun 29, 2019

SMillerDev commented Jul 1, 2019

chenrui333 commented Oct 3, 2019

iMichka commented Oct 10, 2019

Moisan commented Oct 15, 2019

Moisan commented Nov 9, 2019

fxcoudert commented Nov 9, 2019

fxcoudert commented Nov 9, 2019

fxcoudert commented Nov 14, 2019

alebcay commented Nov 14, 2019

fxcoudert commented Nov 14, 2019

SMillerDev commented Nov 14, 2019

giflib 5.2.1 #41436

giflib 5.2.1 #41436

Conversation

alebcay commented Jun 28, 2019

alebcay commented Jun 29, 2019

SMillerDev commented Jul 1, 2019

chenrui333 commented Oct 3, 2019

iMichka commented Oct 10, 2019

Moisan commented Oct 15, 2019

Moisan commented Nov 9, 2019

fxcoudert commented Nov 9, 2019

fxcoudert commented Nov 9, 2019

fxcoudert commented Nov 14, 2019

alebcay commented Nov 14, 2019

fxcoudert commented Nov 14, 2019

SMillerDev commented Nov 14, 2019