Feed module migration #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add service function listFeed Add resolver getFeeds
|
This pull request has been linked to Shortcut Story #2476: Feed module migration. |
Refactor listFeed function in buyerService
DmytroLaikov
requested review from
a team,
AndrewZinko,
anhromovyi,
bnwebdev,
medreres and
dmytroipatov
and removed request for
a team
bnwebdev
suggested changes
Oct 2, 2023
dmytroipatov
suggested changes
Oct 2, 2023
medreres
suggested changes
Oct 3, 2023
src/modules/buyer/dto/categoryGroups/category-group-data-dto.ts
Outdated
Show resolved
Hide resolved
src/modules/buyer/dto/categoryGroups/category-group-data-dto.ts
Outdated
Show resolved
Hide resolved
src/modules/buyer/dto/categoryGroups/category-group-data-item-dto.ts
Outdated
Show resolved
Hide resolved
...dules/buyer/dto/categoryGroups/categoryGroups.utils/categoryGroupDataDtoToInternalReducer.ts
Outdated
Show resolved
Hide resolved
src/modules/buyer/dto/categoryGroups/categoryGroups.utils/categoryGroupDtoToExternalMapper.ts
Outdated
Show resolved
Hide resolved
src/modules/buyer/dto/categoryGroups/categoryGroups.utils/categoryGroupDtoToInternalReducer.ts
Outdated
Show resolved
Hide resolved
dmytroipatov
suggested changes
Oct 3, 2023
bnwebdev
suggested changes
Oct 3, 2023
Separate category-groups into separate module
bnwebdev
suggested changes
Oct 3, 2023
…nges corresponding to unpack data into CategoryGroup object on server
dmytroipatov
suggested changes
Oct 3, 2023
src/category-group/dto/category-group.utils/category-group-dto-items-to-internal-util.ts
Outdated
Show resolved
Hide resolved
src/category-group/dto/category-group.utils/category-groups-dto-to-external-util.ts
Outdated
Show resolved
Hide resolved
src/category-group/dto/category-group.utils/category-groups-dto-to-internal-util.ts
Outdated
Show resolved
Hide resolved
bnwebdev
suggested changes
Oct 4, 2023
src/modules/category-group/dto/dto-utils/category-group-dto-items-to-internal.ts
Outdated
Show resolved
Hide resolved
src/modules/category-group/dto/dto-utils/category-group-dto-items-to-internal.ts
Outdated
Show resolved
Hide resolved
src/modules/category-group/dto/dto-utils/category-groups-dto-to-internal.ts
Outdated
Show resolved
Hide resolved
medreres
reviewed
Oct 4, 2023
dmytroipatov
suggested changes
Oct 4, 2023
src/modules/category-group/dto/dto-utils/category-group-dto-items-to-internal.ts
Outdated
Show resolved
Hide resolved
AndrewZinko
suggested changes
Oct 4, 2023
src/modules/category-group/dto/dto-utils/category-group-dto-items-to-internal.ts
Outdated
Show resolved
Hide resolved
src/modules/category-group/dto/dto-utils/category-groups-dto-to-internal.ts
Outdated
Show resolved
Hide resolved
DmytroLaikov
requested review from
bnwebdev,
medreres,
AndrewZinko and
dmytroipatov
dmytroipatov
previously approved these changes
Oct 5, 2023
AndrewZinko
previously approved these changes
Oct 5, 2023
bnwebdev
previously approved these changes
Oct 5, 2023
DmytroLaikov
dismissed stale reviews from dmytroipatov, bnwebdev, and AndrewZinko
via
050dae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #2476 Feed module migration
Dependant PRs:
Add Feed dto classes
Add service function listFeed
Add resolver getFeeds